Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a Sax Parser based on the Ox gem: https://github.com/ohler55/ox
There is one test pertaining to scrubbing invalid encodings that I have no idea what to do to resolve to the expectation. I tried passing the given XML into the existing scrub_xml method, but it did not make the test pass and seems such pre-processing would defeat the purpose of SAX parsing anyhow. I noticed the other two Parsers aren't scrubbing XML, either, so how they pass this test is beyond me. Personally, I'd say this doesn't really seem like a valid use-case to be concerned with in the library and should be removed altogether. It should be the user's responsibility to pass correctly encoded strings to the library.
Anyway, The Ox parser is working very well and I've already put it to use in our production environment. Hopefully, you'll find this a good addition to this library.